Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline/ray-tracing/axion-field/Validation.C adding extra info #54

Merged
merged 2 commits into from
Apr 19, 2023
Merged

pipeline/ray-tracing/axion-field/Validation.C adding extra info #54

merged 2 commits into from
Apr 19, 2023

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Apr 18, 2023 •
edited by pull-request-badge bot
Loading

jgalan Ok: 2

It adds more information on the validation pipeline to understand which is the source of pipeline error at the following PR rest-for-physics/framework#393

@jgalan
Copy link
Member Author

jgalan commented Apr 19, 2023

Plz @lobis @juanangp could you help me to understand the issue with this PR pipeline?

@jgalan jgalan requested review from lobis and juanangp April 19, 2023 08:08
@juanangp
Copy link
Member

juanangp commented Apr 19, 2023 •
edited
Loading

Plz @lobis @juanangp could you help me to understand the issue with this PR pipeline?

Perhaps because your branch is behind master? Just added some status check to make this visible in the PR

@jgalan jgalan merged commit 21e1bf1 into master Apr 19, 2023
@jgalan jgalan deleted the jgalan-add-validation-info branch April 19, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanangp juanangp juanangp approved these changes

@lobis lobis Awaiting requested review from lobis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgalan @juanangp